Update WP template_root for multisite subsites when applicable #848
Conversation
fullyint
force-pushed
the
wp-template-root
branch
from
7fc1643 to
9ab2d56
Compare
Fixes problem occurring when site1 lacks template_root output, resulting in missing newline in wp_template_root var, ultimately causing stdout_lines to parse incorrectly when resetting template_root. Also switches to submitting pre-filtered wp_template_root.stdout_lines to the with_nested loop in effort to prevent Ansible output littered with numerous skipped subsites for large multisite installations.
When a child theme is in Bedrock `web/app/themes` and its parent theme is in different directory (e.g., `web/wp/wp-content/themes`), stylesheet_root must be `/themes` while template_root should be updated with the latest deploy releases_path. Prior to this PR, stylesheet_root was always updated with template_root, causing problems for some child themes.
|
The third commit When a child theme is in Bedrock |
Some WP themes may throw errors if loaded in this context, e.g., some PHP classes may not be available with `--skip-plugins`. It is not necessary to load themes when updating WP options for template_root and stylesheet root, so it is safer to `--skip-themes`.
|
The fourth commit Some WP themes may throw errors if loaded in this context, e.g., some PHP classes may not be available with Trellis already uses |
|
Closing. Will split into small chunks for easier testing and review. |
Followup to #840 and its history. Fixes https://discourse.roots.io/t/multisite-subsite-using-twentyfifteen-theme/9871/5
This PR enables Trellis deploys to update
template_rootandstylesheet_rootWP options also for multisite subsites, not just the primary site.Multisite operators that wish to disable all this (e.g., in order to avoid the processing time) may add
update_wp_theme_paths: falsesomewhere in group_vars, or disable it on the fly:Re:
xargsetc, see also https://danielbachhuber.com/tip/run-wp-cli-command-wordpress-multisite/Re:
boolfilter, it is necessary for proper interpretation of cli-e update_wp_theme_paths=false(otherwise the var remains a string "false" interpreted as boolean true).No longer assumes that
template_rootandstylesheet_rootare within a.../web/wp/wp-content/themessubdirectory of thereleases_directory(although I don't know where else they'd be).