Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for per-project packagist.com authentication #762

Merged
merged 9 commits into from
Feb 20, 2017

Conversation

nathanielks
Copy link
Contributor

@nathanielks nathanielks commented Feb 16, 2017

This enables the use of a per-site packagist.com token in wordpress_sites.yml:

wordpress_sites:
  example.com:
    packagist_token: "{{ vault_example_com_packagist_token }}"
  foobar.com:
    packagist_token: "{{ vault_foobar_com_packagist_token }}"

If the token is present, it will configure that site on each deploy with the token before installing composer dependencies.

@swalkinshaw
Copy link
Member

Shouldn't this use a vault var?

@nathanielks
Copy link
Contributor Author

The idea would be:

wordpress_sites:
  example.com:
    packagist_token: "{{ vault_example_com_packagist_token }}"
  foobar.com:
    packagist_token: "{{ vault_foobar_com_packagist_token }}"

@swalkinshaw
Copy link
Member

Oops, correct. Was just going by your example code which I assumed was from wordpress_sites.yml and not from vault.yml.

I'd just update that to expand the example.

@nathanielks
Copy link
Contributor Author

Description updated!

@swalkinshaw
Copy link
Member

swalkinshaw commented Feb 19, 2017

This looks good but can we do it without the two "helper" vars. They aren't needed and we should try and avoid them unless it really helps.

@swalkinshaw swalkinshaw merged commit 5cd8c27 into master Feb 20, 2017
@swalkinshaw
Copy link
Member

👏

@swalkinshaw swalkinshaw deleted the configure-packagist-com branch February 20, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants