Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic git repo host keys to known_hosts #751

Merged
merged 2 commits into from
Feb 12, 2017
Merged

Add basic git repo host keys to known_hosts #751

merged 2 commits into from
Feb 12, 2017

Conversation

fullyint
Copy link
Contributor

@fullyint fullyint commented Feb 10, 2017

#475 (comment) describes how to populate a remote server's known_hosts via deploy hook. The purpose is to avoid the host key verification failed error during the composer install task.

This PR makes the known_hosts handling part of Trellis core:

  • avoids the error for the Vagrant VM (wordpress-install role) too
  • users no longer need the deploy hook

I included both rsa and ed25519 key types for GitLab. These work with current master and with the HostKeyAlgorithms that #744 will apply to the SSH client. I avoided the ecdsa type for GitLab because it will be disallowed after #744.

GitHub and Bitbucket seem to only offer the rsa type, before and after #744.

Docs in roots/docs#78

@swalkinshaw
Copy link
Member

Good stuff 🚀

@swalkinshaw
Copy link
Member

changelog and :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants