Vagrant: add automatic support for landrush #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,8 +63,12 @@ Vagrant.configure('2') do |config| | |||
| config.hostmanager.enabled = true | |||
| config.hostmanager.manage_host = true | |||
| config.hostmanager.aliases = hostnames + redirects | |||
| elsif Vagrant.has_plugin? 'landrush' | |||
There was a problem hiding this comment.
This probably isn't going to work as expected, many users will have both hostmanager and landrush installed.
swalkinshaw
force-pushed
the
add-landrush-to-vagrantfile
branch
from
ad56ce8 to
437b28f
Compare
Previously we documented these changes that people would need to manually make. This handles it automatically so landrush is supported out of the box if the user installs the plugin.
swalkinshaw
force-pushed
the
add-landrush-to-vagrantfile
branch
from
437b28f to
6f004d9
Compare
swalkinshaw
changed the title
Vagrantfile: add automatic support for landrush
swalkinshaw
changed the title
Vagrantfile: add automatic support for landrush 
|
Much better, you are my hero wilkinsin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we documented these changes that people would need to manually make. This handles it automatically so landrush is supported out of the box if the user installs the plugin.