Enable per-site setup for permalink structure #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
fullyint
commented
Sep 28, 2016
|
|
||
| - name: Setup Permalink Structure | ||
| command: wp rewrite structure {{ item.value.initial_permalink_structure | default("/%postname%/") }} --allow-root | ||
| command: wp rewrite structure {{ wordpress_sites[item.item.key].initial_permalink_structure | default("/%postname%/") }} --allow-root |
There was a problem hiding this comment.
I'm going to push a commit that changes the two instances of wordpress_sites[item.item.key] to item.item.value. That should be simpler and more closely resemble the existing code. We'll want to squash before merging.
I failed to consider that the values needed were contained in the registered variable, so we don't need to call on the wordpress_sites dict.
|
Changelog? Then 🚀 Looks way better 👍 |
fullyint
force-pushed
the
permalinks-per-site
branch
from
35394b4 to
d92ddea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #660