Fix #563 - Improve remote databases #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
swalkinshaw
force-pushed
the
improve-remote-databases
branch
2 times, most recently
from
f570160 to
30d98d1
Compare
Previously you had to manually toggle the remote database option via `mysql_remote_database` (which also didn't fully work). Now Trellis automatically detects if the sites are using a remote `db_host` or not (aka not `localhost`) and handles things accordingly. This also installs the mysql-client now regardless.
swalkinshaw
force-pushed
the
improve-remote-databases
branch
from
30d98d1 to
255c461
Compare
|
@swalkinshaw that skips the tasks also if 127.0.0.1 is defined, that was confusing and time-consuming to see 🐼 |
| @@ -0,0 +1 @@ | |||
| site_uses_local_db: "{{ site_env.db_host == 'localhost' }}" | |||
There was a problem hiding this comment.
We could. I kind of thought about that but figured there's no reason for anyone to put 127.0.0.1? Trellis configures localhost automatically.
Want to do a PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you had to manually toggle the remote database option via
mysql_remote_database(which also didn't fully work).Now Trellis automatically detects if the sites are using a remote
db_hostor not (aka notlocalhost) and handles things accordingly.This also installs the mysql-client now regardless.