Disable MariaDB binary logging by default #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,10 +17,18 @@ | |||
| name: mariadb-server | |||
| state: present | |||
|
|
|||
| - name: Start MariaDB MySQL Server | |||
| - name: Disable MariaDB binary logging | |||
| when: binary_logging_disabled | |||
There was a problem hiding this comment.
Small thing but can the when condition be put after the template action? That way it's consistent with the rest of the codebase.
|
Thanks @duncanjbrown. Looks good other than my one comment 👍 |
This feature eats up disk space, and it’s not necessary unless you’re doing DB replication, in which case you’ll have other things to configure anyway.
This task was previously `Start`. It did nothing, because the `Install` task already started the server. Now that there is extra config to pick up, a restart is necessary.
duncanjbrown
force-pushed
the
disable-binary-logging
branch
from
32719d2 to
d05170b
Compare
|
Updated |
|
Thanks :) |
swalkinshaw
added a commit
that referenced
this pull request
Mar 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520