Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #412 - Stop cron job emails #421

Merged
merged 1 commit into from
Nov 25, 2015
Merged

Fixes #412 - Stop cron job emails #421

merged 1 commit into from
Nov 25, 2015

Conversation

nbyloff
Copy link
Contributor

@nbyloff nbyloff commented Nov 21, 2015

Supersedes #414

Resolves issue #412

@retlehs
Copy link
Member

retlehs commented Nov 22, 2015

anyone know if we need to use/should use wp-cron.php?doing_wp_cron instead of just wp-cron.php?

@swalkinshaw
Copy link
Member

Good catch. It definitely should. WP uses it in a few places to alter behaviour: https://github.com/WordPress/WordPress/search?utf8=%E2%9C%93&q=doing_wp_cron

@nbyloff
Copy link
Contributor Author

nbyloff commented Nov 23, 2015

Don't they automatically set it if it's not provided?

doing_cron section

Especially since this is set: define('DISABLE_WP_CRON', true);

From what I understand, that makes it so the transients aren't even used?

@swalkinshaw
Copy link
Member

@nbyloff good catch, think you're correct it's not needed.

swalkinshaw added a commit that referenced this pull request Nov 25, 2015
Fixes #412 - Stop cron job emails
@swalkinshaw swalkinshaw merged commit 21ec0aa into roots:master Nov 25, 2015
@nbyloff nbyloff deleted the cron-email branch February 22, 2016 21:47
@retlehs retlehs mentioned this pull request Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants