Disable HSTS includeSubdomains by default #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tangrufus
approved these changes
Jul 21, 2022
Ref #741 This changes the default for HSTS' `includeSubdomains` value from `true` to `false`. Previously a user visiting a WordPress site would result in HSTS being enabled in their browser for _all_ subdomains of the site's domain. Now HSTS will only apply to the hostnames activately managed by Trellis in the `wordpress_sites.yml` config. This is a safer default since subdomains can frequently exist without SSL.
swalkinshaw
force-pushed
the
hsts-disable-include-subdomains-by-default
branch
from
28d1beb to
6c78027
Compare
swalkinshaw
added a commit
to roots/docs
that referenced
this pull request
Jul 21, 2022
This reflects the new default in roots/trellis#1409
swalkinshaw
added a commit
to roots/docs
that referenced
this pull request
Jul 21, 2022
This reflects the new default in roots/trellis#1409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #741
This changes the default for HSTS'
includeSubdomainsvalue fromtruetofalse. Previously a user visiting a WordPress site would result in HSTS being enabled in their browser for all subdomains of the site's domain. Now HSTS will only apply to the hostnames activately managed by Trellis in thewordpress_sites.ymlconfig.This is a safer default since subdomains can frequently exist without SSL.
Note: this is a breaking change for anyone who never disabled this manually. Provisioning this change will result in subdomains being excluded from HSTS. If you want this behaviour, and we recommend it where possible, you'll need to manually opt back into it:
Per site:
Globally:
Docs update: roots/docs#417