Add ansible-base to requirements #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
force-pushed
the
add-ansible-base-to-requirements
branch
3 times, most recently
from
32bb7a6 to
4f9c642
Compare
Bumps minimum required Ansible to >= 2.10 as well. The Ansible ecosystem has changed how their versions and packages work causing the main `ansible` package versions to no longer determine the version of `ansible-playbook`. Instead, the new `ansible-base` package is what matters. Background: https://blog.while-true-do.io/ansible-release-3-0-0/ For example, installing `ansible==2.10.7` would result in `ansible-playbook==2.10.16` which was confusing. By adding `ansible-base` to our `requirements.txt`, we'll get more consistent and predictable version constraints. Installing `ansible-base==2.10.16` would result in `ansible-playbook==2.10.16` as you'd expect.
swalkinshaw
force-pushed
the
add-ansible-base-to-requirements
branch
from
4f9c642 to
32b1625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ansible ecosystem has changed how their versions and packages work causing the main
ansiblepackage versions to no longer determine the version ofansible-playbook. Instead, the newansible-basepackage is what matters.Background: https://blog.while-true-do.io/ansible-release-3-0-0/
For example, installing
ansible==2.10.7would result inansible-playbook==2.10.16which was confusing.By adding
ansible-baseto ourrequirements.txt, we'll get more consistent and predictable version constraints.Installing
ansible-base==2.10.16would result inansible-playbook==2.10.16as you'd expect.