Validate that letsencrypt_contact_emails is a list #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already validate that `letsencrypt_contact_emails` needs to be defined. This further validates that it's defined as a list and not a string.
tangrufus
approved these changes
Nov 10, 2020
swalkinshaw
deleted the
add-more-letsencrypt_contact_emails-validation
branch
jeffbyrnes
added a commit
to abundanthomesma/abundanthousingma.org
that referenced
this pull request
Nov 21, 2020
Basically Trellis v1.7.0, plus roots/trellis#1250
jeffbyrnes
added a commit
to abundanthomesma/abundanthousingma.org
that referenced
this pull request
Dec 13, 2020
Basically Trellis v1.7.0, plus roots/trellis#1250
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already validate that
letsencrypt_contact_emailsneeds to be defined. This further validates that it's defined as a list and not a string.Ref: https://discourse.roots.io/t/unable-to-update-account-too-many-contacts-provided/19153
cc @strarsis