Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DEPLOY_UNFINISHED not being copied over to release #1145

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

tangrufus
Copy link
Member

@tangrufus tangrufus commented Jan 21, 2020

The tar generated by git archive doesn't include DEPLOY_UNFINISHED

- name: Run git archive to populate new build dir
shell: git archive {{ project_version }} | tar xf - -C {{ deploy_helper.new_release_path }}
args:
chdir: "{{ project_source_path }}"
when: project.repo_subtree_path is not defined
- name: Run git archive with subdirectory to populate new build dir
shell: git archive {{ project_version }} {{ project.repo_subtree_path }} | tar -x --strip-components {{ project.repo_subtree_path.split('/') | count }} -f - -C {{ deploy_helper.new_release_path }}
args:
chdir: "{{ project_source_path }}"
when: project.repo_subtree_path is defined

@swalkinshaw
Copy link
Member

😱 nice catch

@tangrufus
Copy link
Member Author

tangrufus commented Jan 21, 2020

Should we tag this as a breaking change?

Before this PR, failed releases count towards deploy_keep_releases. Failed releases only being deleted when reaching deploy_keep_releases.

After this PR, a successful deploy removes all releases with DEPLOY_UNFINISHED during finalize.

The new behavior breaks how rollback.yml works currently.

@swalkinshaw
Copy link
Member

It's technically breaking but it seems like it's correcting behaviour more than anything (behaviour which people probably didn't notice?)

@tangrufus tangrufus merged commit 1bc2bf1 into roots:master Jan 22, 2020
@tangrufus tangrufus deleted the deploy-unfinished branch January 22, 2020 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants