Use Ruby for ssh-config trigger #1053
Conversation
| @@ -136,10 +136,10 @@ Vagrant.configure('2') do |config| | |||
| if !Vagrant::Util::Platform.windows? | |||
There was a problem hiding this comment.
Shouldn't this be enabled on Windows now that it no longer relies on bash? 🤔
There was a problem hiding this comment.
~/.ssh/config is a safe assumption on Windows as well?
There was a problem hiding this comment.
%userprofile%/.ssh/config in windows parlance, where userprofile is an environment variable to the user's home directory. while not all versions of windows come with openssh (windows 10 comes with it since earlier this year), git requires ssh, and so most windows users who are using trellis will probably have openssh and this is a safe assumption in those cases.
There was a problem hiding this comment.
And if that file exists, we can safely assume it's the same format I'm guessing?
There was a problem hiding this comment.
Yeah, it follows the same format, but one thing that would concern is me is whether the path to the private key is in the windows (e.g., d:\Sites\example.com\trellis\etc...) or unix (e.g., /mnt/d/Sites/example.com/trellis/etc...) format. There's probably not an easy way to handle this, but I'm thinking we could rely on Ruby/Vagrant to figure it out.
My Ruby is terrible, but I can test whatever you wanna send me.
There was a problem hiding this comment.
Let's do this separately after I merge this 👍
Vagrantfile
Outdated
| args: [main_hostname] | ||
| } | ||
| trigger.info = "Adding vagrant ssh-config for #{main_hostname } to ~/.ssh/config" | ||
| trigger.ruby do |_, _| |
There was a problem hiding this comment.
Can we omit the block parameters?
- trigger.ruby do |_, _|
+ trigger.ruby do
swalkinshaw
force-pushed
the
ssh-trigger-use-ruby-script
branch
2 times, most recently
from
39241d5 to
a5bc6e0
Compare
This replaces the bash implementation in #1042 with a Ruby one instead.
It has some improvements and safety guards. Most important of all, it creates a backup of the existing config file before doing anything.