Hyper-V and SMB folder sync compatibility #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should add some support for Hyper-V, which also uses SMB folder shares.
There are a few intricacies with using Hyper-V, which I might try and outline either in a blog post or in the docs. It seems like it's come a long way and should be a nice option going forward for Windows users, especially if they also have Docker for Windows installed.
Only thing I wasn't sure about was creating another conditional for the folder syncs. However we need to supply the SMB username and password, and I wasn't sure if it's possible to conditionally pass arguments.