Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♿️ Add accessible names to nav elements #3179

Merged
merged 4 commits into from
Jan 18, 2024
Merged

♿️ Add accessible names to nav elements #3179

merged 4 commits into from
Jan 18, 2024

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Jan 18, 2024

Close #3105

@retlehs retlehs requested a review from knowler January 18, 2024 19:07
@retlehs retlehs self-assigned this Jan 18, 2024
@github-actions github-actions bot added views php Pull requests that update PHP code labels Jan 18, 2024
knowler
knowler requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@knowler knowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some related code changes. You can drop the word “navigation” since screen readers will already announce that after the label (otherwise it’ll say “Page navigation navigation”).

resources/views/partials/content-single.blade.php Outdated Show resolved Hide resolved
resources/views/partials/content-page.blade.php Outdated Show resolved Hide resolved
resources/views/partials/comments.blade.php Outdated Show resolved Hide resolved
retlehs and others added 3 commits January 18, 2024 13:16
@retlehs @knowler
Update resources/views/partials/content-single.blade.php
51313ce 
Co-authored-by: Nathan Knowler <nathan@knowler.me>
@retlehs @knowler
Update resources/views/partials/content-page.blade.php
a10fe89 
Co-authored-by: Nathan Knowler <nathan@knowler.me>
@retlehs @knowler
Update resources/views/partials/comments.blade.php
48523ba 
Co-authored-by: Nathan Knowler <nathan@knowler.me>
@retlehs retlehs requested a review from knowler January 18, 2024 19:16
@retlehs retlehs merged commit 0365fb2 into main Jan 18, 2024
4 checks passed
@retlehs retlehs deleted the nav-accessibility branch January 18, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knowler knowler knowler approved these changes

Assignees

@retlehs retlehs

Labels
php Pull requests that update PHP code views
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: additional <nav> elements in partials need accessible names
2 participants
@retlehs @knowler