Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Move default theme markup to the app layout #3167

Merged
merged 5 commits into from
Jan 5, 2024
Merged

🎨 Move default theme markup to the app layout #3167

merged 5 commits into from
Jan 5, 2024

Conversation

Log1x
Copy link
Member

@Log1x Log1x commented Dec 19, 2023

After testing with Debug Bar, it appears that moving the default theme markup to the app layout does not have any negative side-effects like before seen with Sage 9 (e.g. #2116). Another pair of eyes to confirm would be cool.

Alongside being cleaner to maintain this stuff in Blade, this also fixes a lot of inconsistencies/rendering issues with Acorn's exception handler.

Change log

🐛 Fix uncontrollable HTML output (Fixes #3166)
@github-actions github-actions bot added views php Pull requests that update PHP code labels Dec 19, 2023
@Log1x Log1x requested a review from retlehs December 19, 2023 02:22
@Log1x Log1x self-assigned this Dec 19, 2023
@Log1x Log1x requested a review from QWp6t December 19, 2023 02:28
Copy link
Member

@retlehs retlehs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We'll ship this in the next Sage release once Acorn v4 is out

@Log1x Log1x merged commit 6f46605 into main Jan 5, 2024
4 checks passed
@Log1x Log1x deleted the fix/3166 branch January 5, 2024 17:08
@jeremylind
Copy link

I think wp_head() needs to be called in index.php outside the app context in order to properly enqueue scripts. In my testing, with a block with block.json defining a view script, the script is not enqueued when wp_head() is in the app layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update PHP code views
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do_action('get_header') should occur before wp_head() Admin bar breaking error pages
4 participants