Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Acorn v3 (Laravel 9.x), drop PHP 7.4 support #3097

Merged
merged 5 commits into from
Jan 27, 2023
Merged

🔧 Acorn v3 (Laravel 9.x), drop PHP 7.4 support #3097

merged 5 commits into from
Jan 27, 2023

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Oct 16, 2022

These changes are required to upgrade to Acorn v3

TODOs

Ref https://github.com/roots/acorn/releases

@github-actions github-actions bot added the php Pull requests that update PHP code label Oct 16, 2022
@retlehs retlehs changed the title 🔧 Acorn v3 🔧 Acorn v3 (Laravel 9.x) Oct 16, 2022
@retlehs retlehs changed the title 🔧 Acorn v3 (Laravel 9.x) 🔧 Acorn v3 (Laravel 9.x), drop PHP 7.4 support Oct 16, 2022
@Striffly
Copy link

Any update for this ? Some dependencies (like php-ffmpeg) seems to not be compatible with roots/acorn v2 :

Fatal error: Declaration of Illuminate\Container\Container::has($id) must be compatible with Psr\Container\ContainerInterface::has(string $id): bool in /app/vendor/illuminate/container/Container.php on line 194

Upgrading to roots/acorn v3 seems to resolve this issue, but we can't show any view for the moment...

@retlehs
Copy link
Member Author

retlehs commented Nov 29, 2022

Upgrading to roots/acorn v3 seems to resolve this issue, but we can't show any view for the moment..

What update are you looking for? This PR demonstrates how to correctly upgrade to Acorn v3 and doesn't contain the error that you're describing. It's not going to be merged until Acorn v3 has a stable release.

@Striffly
Copy link

After upgrading, I got this error too : Target class [sage.view] does not exist.

@Log1x
Copy link
Member

Log1x commented Nov 29, 2022

After upgrading, I got this error too : Target class [sage.view] does not exist.

Double check your ThemeServiceProvider making sure it extends SageServiceProvider and has parent:: calls to register() and boot() if they are present. You can reference my latest commit.

@retlehs retlehs marked this pull request as ready for review January 27, 2023 22:36
@retlehs retlehs merged commit 03386f0 into main Jan 27, 2023
@retlehs retlehs deleted the acorn-v3 branch January 27, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update PHP code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants