Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Use wp i18n update-po for updating PO files #3081

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

strarsis
Copy link
Contributor

This PR replaces the existing shell script with a wp i18n invocation for the newly added update-po subcommand that updates the PO files with the POT file.

This eliminates the need for external tooling (except for the wp CLI of course) and shell scripts.

The latest wp i18n version (>=2.4.0) is needed for the newly added update-po subcommand.
Until wp CLI is also newly released with the new wp i18n version bundled,
the latest wp i18n version can be installed independently from the wp CLI version by using
wp package install wp-cli/i18n-command:dev-main
and then just using it as usual (wp i18n).

Replace the existing shell script as `npm` script with a `wp i18n` invocation of the newly added `update-po` subcommand that updates the PO files with the POT file.
@strarsis
Copy link
Contributor Author

@retlehs, @bonakor: Trying with the latest stable WP CLI, the command appears to work now without installing edge/dev versions of WP CLI or the i18n package, so this can be merged now!

@retlehs
Copy link
Member

retlehs commented Feb 22, 2023

@strarsis Thank you!

@retlehs retlehs changed the title Use wp i18n update-po for updating PO files 🔧 Use wp i18n update-po for updating PO files Feb 22, 2023
@retlehs retlehs merged commit d6e6e21 into roots:main Feb 22, 2023
alex-kcg pushed a commit to Kalos-Creative-Group/sage that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants