-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sage 10 #2138
Merged
Merged
Sage 10 #2138
Changes from all commits
Commits
Show all changes
145 commits
Select commit
Hold shift + click to select a range
2467d95
Sage 10 (#2122)
QWp6t 603bfdd
Merge branch 'master' into 10.0.0-dev
QWp6t 27167b6
Add wp_body_open hook (WP 5.2+)
retlehs da723af
Add missing search blade
Log1x 5c72cc9
Add WP Blade Check
Log1x e5505a4
Remove redundant ARIA roles
Log1x e3888bb
Revert language_attributes() to get_language_attributes()
Log1x 0e4df1e
Make searchform translations match WordPress core
Log1x a3fa3e0
Merge pull request #2171 from Log1x/10.0.0-dev
retlehs 2893958
️Merge branch 'master' into 10.0.0-dev
retlehs b083b89
Update Travis conf
retlehs eb34767
rmdist is gone in Sage 10
retlehs 4f9222b
Change to Laravel Mix
Log1x e1c943d
Fix merge conflicts
Log1x 59289e7
Simplify Blade cache removal
Log1x 2e082bf
Use ->uri() on asset for sanity purposes
Log1x 9117058
Fix app.js typo
Log1x 33566ab
Merge pull request #2172 from Log1x/10.0.0-dev
retlehs ffa1fd7
Add npm-run-all
knowler 51b7d5d
Add -c (continue on error) flag to lint command
knowler f5c5d28
run-s all the things
knowler 1c418b4
Refactor build commands
knowler c46ef7b
Fix start command
knowler dd151a0
Fix hot command
knowler b2511c2
Merge pull request #2173 from roots/sage-10-add-npm-run-all
retlehs aad9f79
Move cache location to `storage/`
Log1x f3edfe7
Remove redundent $asset in setup.php
Log1x 29e6dd2
Merge pull request #2174 from Log1x/10.0.0-dev
retlehs 7033c34
Add clean:views npm script (#2176)
knowler 1cf759e
[Sage 10] Add src and public mix path helpers (#2177)
knowler 71af56c
Typo [ci skip]
retlehs 6db4199
Syntax optimizations
knowler 1a86124
Use out instead of public for publicPath helper
knowler e8167f5
Use publicPath instead of out
knowler dba5cbf
Use Roots\Acorn\ServiceProvider (#2180)
knowler 0c65766
Merge pull request #2179 from knowler/10-mix-golf
retlehs e1a7965
Make editorconfig account for Blade's outside of resources/views
Log1x 04102fa
Merge pull request #2183 from Log1x/patch-1
retlehs 108aafe
non-Blade files located in resources/views should also be indent_size…
Log1x 0f5cf8a
[Sage 10] Replace jQuery’s .ready() (#2182)
knowler a43790c
Merge pull request #2184 from Log1x/patch-2
retlehs 9c6a51c
Merge branch '10.0.0-dev' into wp_body_open-hook
retlehs 892ae84
Merge pull request #2167 from roots/wp_body_open-hook
retlehs cd05a13
Replace Travis CI with CircleCI (#2185)
retlehs e907401
Replace badge [ci skip]
retlehs 8c1ed95
Optimize CircleCI (#2186)
Log1x a367176
Update .gitattributes
retlehs f4b1ca6
Update .gitattributes
retlehs 9979ef1
Optimize CircleCI config (#2188)
tangrufus cc8898f
Update composer dependencies
QWp6t ea60923
Bump required WordPress version (#2193)
Log1x cf15e45
Restructure (#2200)
QWp6t 260925d
Fix version_compare() operators (#2195)
Log1x c3ae1fb
Simplify Mix Browsersync API (#2198)
knowler 07275ac
New DOM router + dynamic imports (#2190)
QWp6t 3b8faa1
Update dependencies
QWp6t 2e14a43
Add post-autoload-dump script for package discovery (#2201)
Log1x 808addd
CircleCI: `yarn install` with `--frozen-lockfile` (#2203)
tangrufus 83afc41
Bump babel-eslint from 10.0.1 to 10.0.2 (#2209)
dependabot-preview[bot] 4e95f03
Bump sass from 1.21.0 to 1.22.0 (#2211)
dependabot-preview[bot] 57499b2
Bump eslint-plugin-import from 2.17.3 to 2.18.0 (#2210)
dependabot-preview[bot] 6961eba
Bump eslint from 5.16.0 to 6.0.1 (#2212)
dependabot-preview[bot] e507645
Fix npm run start script options not forwarded with npm (#2205)
oxyc 98efe4c
Use WordPress’ Browserslist config (#2214)
knowler 3f173b4
Bump sass from 1.22.0 to 1.22.1 (#2216)
dependabot-preview[bot] de1249c
Bump sass from 1.22.1 to 1.22.3 (#2218)
dependabot-preview[bot] e7f86c6
Bump laravel-mix from 4.0.16 to 4.1.2 (#2219)
dependabot-preview[bot] 8f12829
Update README [ci skip]
retlehs a714074
[Security] Bump lodash from 4.17.11 to 4.17.14 (#2259)
dependabot-preview[bot] ea303be
Bump sass from 1.22.3 to 1.22.4 (#2260)
dependabot-preview[bot] 6bd5d65
chore(readme): Use brand color for Twitter follow badge
QWp6t 676ca39
Acorn asset manager config (#2220)
QWp6t b23186e
Add logs directory
Log1x 6d3ea05
Merge pull request #2264 from roots/log1x/add-log-dir
Log1x a6c0beb
Bump sass from 1.22.4 to 1.22.5 (#2263)
dependabot-preview[bot] b9b743d
Add alert component with view composer (#2267)
knowler 399ab45
Fix broken source maps + remove unnecessary conditionals (#2268)
knowler a71e76d
chore(config): add alert component alias to view config (#2272)
knowler d462e41
Bump sass from 1.22.5 to 1.22.7 (#2273)
dependabot-preview[bot] 055e9fe
Bump eslint-plugin-import from 2.18.0 to 2.18.2 (#2275)
dependabot-preview[bot] e4573b3
No scripts/suggests during `composer install` on CircleCI [ci skip]
Log1x 3c5e0e6
Add timezone, globals, and locale app config [ci skip]
Log1x 3f6db1a
Add logging config
Log1x 5551ec4
Update theme structure in README [ci skip]
Log1x 4edc43b
Move get_search_form and body_class to Acorn
Log1x 9ab51f1
Bump sass from 1.22.7 to 1.22.9 (#2281)
dependabot-preview[bot] ec2791d
Bump eslint from 6.0.1 to 6.1.0 (#2276)
dependabot-preview[bot] 9bfdb73
Update sponsors [ci skip]
retlehs 80f7a13
Keep a commented out example of calling a Composer class
Log1x 4c335f5
Merge pull request #2280 from roots/log1x/acorn-update
Log1x a99a8f7
Bump dependencies
Log1x 45f4884
Set `wp_nav_menu` echo to `false` (#2278)
Log1x ef14ed9
Bump @wordpress/browserslist-config from 2.5.0 to 2.6.0 (#2282)
dependabot-preview[bot] cefbd04
chore(deps): log1x/sage-directives from 1.0.9 to 1.1.2 (#2286)
dependabot-preview[bot] 0232d87
Bump sass-loader from 7.1.0 to 7.2.0 (#2287)
dependabot-preview[bot] c90c502
Remove unnecessary linebreak [ci skip]
Log1x 6207152
docs(changelog): Use lowercase for "webpack"
knowler 01f6b3c
Bump rimraf from 2.6.3 to 3.0.0 (#2289)
dependabot-preview[bot] f1d09ee
Bump sass from 1.22.9 to 1.22.10 (#2292)
dependabot-preview[bot] 85d9444
Bump sass-loader from 7.2.0 to 7.3.1 (#2293)
dependabot-preview[bot] 058a45e
Bump eslint from 6.1.0 to 6.2.1 (#2294)
dependabot-preview[bot] b1d164f
Bump babel-eslint from 10.0.2 to 10.0.3 (#2295)
dependabot-preview[bot] 2dad674
Bump eslint from 6.2.1 to 6.2.2 (#2296)
dependabot-preview[bot] f0f7a39
Bump log1x/sage-directives from 1.1.2 to 1.1.3 (#2297)
dependabot-preview[bot] 98d45e7
Adds i18n support (#2290)
kellymears c5b86db
Update Composers to work with the latest Acorn
Log1x 1005f6f
Use $this->data in the Alert Composer (#2300)
Log1x 1561b1b
Update sponsors [ci skip]
retlehs 9d9ab09
Update sponsors [ci skip]
retlehs 8dd2658
Update sponsors [ci skip]
retlehs 3e8c421
Call ->render() on view instead of relying on toString (#2330)
Log1x 920744c
Bump for Acorn (#2337)
Log1x 41e4f6d
Use mix-manifest.json (Fixes #2329)
Log1x 13dbdbd
Pre-Sage 10 Alpha (#2338)
Log1x 1790fbf
Inline manifest.js when enqueueing editor.js (#2344)
Log1x b2df923
Add theme color palette support (#2352)
kellymears 61d3550
Bump bootstrap from 4.3.1 to 4.4.1 (#2350)
dependabot-preview[bot] 15a1a01
Bump eslint from 6.6.0 to 6.7.2 (#2354)
dependabot-preview[bot] 36b2c28
Bump sass from 1.23.3 to 1.23.7 (#2345)
dependabot-preview[bot] fdbe712
Sage 10 editor scripts & styles (#2351)
kellymears cef9185
Bump stylelint from 11.1.1 to 12.0.0 (#2342)
dependabot-preview[bot] 09e9db9
Bump squizlabs/php_codesniffer from 3.5.2 to 3.5.3 (#2356)
dependabot-preview[bot] 7dc3bad
README updates for 10.0.0-alpha.1 (#2271)
knowler 9ced9e8
Update setup.php
retlehs a43e6fc
Keep hierarchical assets directory structure (#2372)
oxyc 31ce2b1
fix(stylelint): Fix broken tests (#2375)
Log1x 98397f4
chore(deps): Bump dependencies (#2376)
Log1x 1671198
update laravel-mix-wp-blocks (#2381)
kellymears 7a343ad
Update sponsors [ci skip]
retlehs 4a7ff33
Sage 10 fixes/cleanup (#2413)
Log1x 879119e
Laravel 7.x (#2429)
Log1x f876376
enhance(deps): Add `Requires PHP` and `Requires at least` to theme st…
tangrufus 7f8e828
Sage 10 Chores (#2431)
Log1x 31559f0
Bump roots/acorn from 1.0.2 to 1.0.3 (#2433)
dependabot-preview[bot] 1b6be64
Bump roots/acorn from 1.0.3 to 1.0.4 (#2440)
dependabot-preview[bot] 61e22dd
Bump stylelint from 13.2.1 to 13.3.0 (#2439)
dependabot-preview[bot] 3c64c3a
Update sponsors [ci skip]
retlehs 71c621e
Bump roots/acorn from 1.0.4 to 1.0.6 (#2444)
dependabot-preview[bot] 2886c41
Bump @wordpress/dependency-extraction-webpack-plugin from 2.4.0 to 2.…
dependabot-preview[bot] 0ba13c0
Bump @wordpress/babel-preset-default from 4.11.0 to 4.12.1 (#2450)
dependabot-preview[bot] 4ccca3b
Bump squizlabs/php_codesniffer from 3.5.4 to 3.5.5 (#2451)
dependabot-preview[bot] d56dcef
Bump laravel-mix-copy-watched from 2.2.3 to 2.2.4 (#2452)
dependabot-preview[bot] 60298d8
Bump jquery from 3.4.1 to 3.5.0 (#2445)
dependabot-preview[bot] 9395d9d
Bump stylelint from 13.3.0 to 13.3.3 (#2453)
dependabot-preview[bot] b36d07c
Update README.md
retlehs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
version: 2.1 | ||
|
||
orbs: | ||
sage: | ||
executors: | ||
node-10: | ||
docker: | ||
- image: 'circleci/node:10-stretch' | ||
php-73: | ||
docker: | ||
- image: 'circleci/php:7.3-stretch' | ||
php-72: | ||
docker: | ||
- image: 'circleci/php:7.2-stretch' | ||
jobs: | ||
build-php: | ||
parameters: | ||
executor: | ||
type: executor | ||
executor: << parameters.executor >> | ||
steps: | ||
- run: php -v | ||
- checkout | ||
- restore_cache: | ||
keys: | ||
- composer-v1-{{ checksum "composer.lock" }} | ||
- composer-v1- | ||
- run: composer install -n --prefer-dist --no-scripts --no-suggest | ||
- run: composer lint | ||
- save_cache: | ||
key: composer-v1-{{ checksum "composer.lock" }} | ||
paths: | ||
- vendor | ||
build-node: | ||
executor: node-10 | ||
steps: | ||
- run: yarn versions | ||
- checkout | ||
- restore_cache: | ||
keys: | ||
- node-v1-{{ checksum "yarn.lock" }} | ||
- node-v1- | ||
- run: yarn install --frozen-lockfile | ||
- run: yarn run test | ||
- run: yarn run build:production | ||
- save_cache: | ||
key: node-v1-{{ checksum "yarn.lock" }} | ||
paths: | ||
- node_modules | ||
|
||
workflows: | ||
build: | ||
jobs: | ||
- sage/build-node | ||
- sage/build-php: | ||
name: build-php-73 | ||
executor: sage/php-73 | ||
- sage/build-php: | ||
name: build-php-72 | ||
executor: sage/php-72 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,24 @@ | ||
# editorconfig.org | ||
|
||
root = true | ||
|
||
[*] | ||
charset = utf-8 | ||
end_of_line = lf | ||
insert_final_newline = true | ||
indent_style = space | ||
indent_size = 2 | ||
end_of_line = lf | ||
charset = utf-8 | ||
trim_trailing_whitespace = true | ||
insert_final_newline = true | ||
|
||
[*.md] | ||
trim_trailing_whitespace = false | ||
|
||
[*.php] | ||
indent_size = 4 | ||
|
||
[*.blade.php] | ||
indent_size = 2 | ||
|
||
[resources/views/**.php] | ||
indent_size = 2 | ||
|
||
[index.php] | ||
indent_size = 2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,48 +1,42 @@ | ||
module.exports = { | ||
'root': true, | ||
'extends': 'eslint:recommended', | ||
'globals': { | ||
'wp': true, | ||
root: true, | ||
extends: 'eslint:recommended', | ||
parser: 'babel-eslint', | ||
globals: { | ||
wp: true | ||
}, | ||
'env': { | ||
'node': true, | ||
'es6': true, | ||
'amd': true, | ||
'browser': true, | ||
'jquery': true, | ||
env: { | ||
node: true, | ||
es6: true, | ||
amd: true, | ||
browser: true, | ||
jquery: true | ||
}, | ||
'parserOptions': { | ||
'ecmaFeatures': { | ||
'globalReturn': true, | ||
'generators': false, | ||
'objectLiteralDuplicateProperties': false, | ||
'experimentalObjectRestSpread': true, | ||
parserOptions: { | ||
ecmaFeatures: { | ||
globalReturn: true, | ||
generators: false, | ||
objectLiteralDuplicateProperties: false | ||
}, | ||
'ecmaVersion': 2017, | ||
'sourceType': 'module', | ||
ecmaVersion: 2017, | ||
sourceType: 'module' | ||
}, | ||
'plugins': [ | ||
'import', | ||
], | ||
'settings': { | ||
plugins: ['import'], | ||
settings: { | ||
'import/core-modules': [], | ||
'import/ignore': [ | ||
'node_modules', | ||
'\\.(coffee|scss|css|less|hbs|svg|json)$', | ||
], | ||
'import/ignore': ['node_modules', '\\.(coffee|scss|css|less|hbs|svg|json)$'] | ||
}, | ||
'rules': { | ||
rules: { | ||
'no-console': 0, | ||
'quotes': ['error', 'single'], | ||
'comma-dangle': [ | ||
'error', | ||
{ | ||
'arrays': 'always-multiline', | ||
'objects': 'always-multiline', | ||
'imports': 'always-multiline', | ||
'exports': 'always-multiline', | ||
'functions': 'ignore', | ||
}, | ||
], | ||
}, | ||
arrays: 'always-multiline', | ||
objects: 'always-multiline', | ||
imports: 'always-multiline', | ||
exports: 'always-multiline', | ||
functions: 'ignore' | ||
} | ||
] | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
/.github export-ignore | ||
/.circleci export-ignore | ||
/.gitattributes export-ignore | ||
/.travis.yml export-ignore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,5 @@ | ||
# Include your project-specific ignores in this file | ||
# Read about how to use .gitignore: https://help.github.com/articles/ignoring-files | ||
.cache-loader | ||
dist | ||
node_modules | ||
/node_modules | ||
/vendor | ||
/dist | ||
npm-debug.log | ||
yarn-error.log | ||
/vendor | ||
resources/assets/config-local.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
{ | ||
"extends": "stylelint-config-standard", | ||
"rules": { | ||
"declaration-colon-newline-after": null, | ||
"value-list-comma-newline-after": null, | ||
"no-empty-source": null, | ||
"no-descending-specificity": null, | ||
"at-rule-empty-line-before": null, | ||
"at-rule-no-unknown": [ | ||
true, | ||
{ | ||
"ignoreAtRules": [ | ||
"extend", | ||
"at-root", | ||
"debug", | ||
"warn", | ||
"error", | ||
"if", | ||
"else", | ||
"for", | ||
"each", | ||
"while", | ||
"mixin", | ||
"include", | ||
"content", | ||
"return", | ||
"tailwind", | ||
"apply", | ||
"responsive", | ||
"variants", | ||
"screen", | ||
"function" | ||
] | ||
} | ||
] | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can have regular
.php
files within resources/views. Those should be 2 spaces.And blade files outside of resources/views should ... probably not be outside of resources/views, or they should be vendored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll push a change to handle
resources/views/**.php
– as far as Blade files outside ofresources/views
– there are multiple Sage-specific Gutenberg libraries popping up that are handling the views outside ofresources/views
such as:app/Blocks/Example/Example.php
app/Blocks/Example/views/example.blade.php
app/Blocks/Example/views/example.(css,js)
which despite recommending separating things like this into an mu-plugin, is a somewhat clean approach to handling individual blocks without separating everything into 3 different directories when/if they are done inside of the theme.