Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add searchform partial and function to replace default WordPress functionality #2090

Merged
merged 6 commits into from
Aug 9, 2018
Merged

Add searchform partial and function to replace default WordPress functionality #2090

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ccc2ee
Add searchform partial and function to replace (and maintain) default…
MWDelaney Aug 5, 2018
d93964b
Remove gross WPCS
MWDelaney Aug 6, 2018
b41047f
Add text domain
MWDelaney Aug 6, 2018
e898cf1
Extract logic from search form template
alwaysblank Aug 6, 2018
d13e8fd
Update filters.php
MWDelaney Aug 8, 2018
c1bc6ef
Update filters.php
MWDelaney Aug 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions resources/views/partials/searchform.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<form role="search" method="get" class="search-form" action="{{ esc_url( home_url( '/' ) ) }}">
<form role="search" method="get" class="search-form" action="{{ esc_url(home_url( '/') ) }}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See commit d93964b -- this was already done

<label>
<span class="screen-reader-text">{{ _x( 'Search for:', 'label' ) }}</span>
<input type="search" class="search-field" placeholder="{!! esc_attr_x( 'Search &hellip;', 'placeholder' ) !!}" value="{{ get_search_query() }}" name="s" />
<span class="screen-reader-text">{{ _x('Search for:', 'label') }}</span>
<input type="search" class="search-field" placeholder="{!! esc_attr_x('Search &hellip;', 'placeholder') !!}" value="{{ get_search_query() }}" name="s">
</label>
<input type="submit" class="search-submit" value="{{ esc_attr_x( 'Search', 'submit button' ) }}" />
<input type="submit" class="search-submit" value="{{ esc_attr_x('Search', 'submit button') }}">
</form>