Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detect proxyUrl scheme #2062

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Auto-detect proxyUrl scheme #2062

merged 1 commit into from
Apr 25, 2018

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Apr 25, 2018

sage-installer doesn't set proxyUrl to https if you provided an https URL for your proxyUrl, resulting in issues with browsersync sessions

rather than forcing it in sage-installer, here we're detecting which scheme to use based on devUrl and overriding it for proxyUrl

@retlehs retlehs merged commit 8d001c7 into master Apr 25, 2018
@retlehs retlehs deleted the auto-detect-proxyurl-scheme branch April 25, 2018 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant