Issue #1950: Fix lint:styles script not matching files in deep subdirectories

[oxyc]

Fix #1950 by not relying on the user's shell but rather passing the unexpanded pattern directly to stylelint which in turn expands it using node-glob.

[retlehs]

tyvm 🙏

[mtx-z]

Hey, I just deployed the latest dev-master, and this update cause following error (Windows 8.1/Wamp64 Apache, Node 6.112, npm 3.10.10, Yarn 0.27.5) :

yarn run lint:styles
yarn run v0.27.5
$ stylelint 'resources/assets/styles/**/*.{css,sass,scss,sss,less}'

Error: 'resources/assets/styles/**/*.{css,sass,scss,sss,less}' does not match any files
    at globby.then.filePaths (C:\wamp64\www\project\wp-content\themes\theme\node_modules\stylelint\lib\standalone.js:124:33)
error Command failed with exit code 80.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

yarn run build
yarn run v0.27.5
$ webpack --progress --config resources/assets/build/webpack.config.js
Error: Failed because of a stylelint error.

    at linterSuccess (C:\wamp64\www\project\wp-content\themes\theme\node_modules\stylelint-webpack-plugin\lib\run-compilation.js:34:14)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Removing the added quote around resources/assets/styles/**/*.{css,sass,scss,sss,less} fix the issue.

After removing the quote, run lint:styles correctly output styles errors. But, run build do not throw anything more "useful" than Error: Failed because of a stylelint error. Would be cool to have the Lint output on global build.
errors and errorDetails are true in webpack.config.js.

Test:
Setting StyleLintPlugin failOnError at false seems to finish the build successfuly, even if command end outputing error Command failed with exit code 2. Note that before this last message, Lint errors about my SCSS are outputed.

Related: https://discourse.roots.io/t/yarn-build-error-exit-code-2/10225

[oxyc]

Seems cmd.exe passes along single quotes according to eslint/eslint#5796 (comment). Using double quotes would work just as well on *nix and should fix it on Windows I guess. @mtx-z could you test if it works if you change the task in package.json to use " rather than '.

[oxyc]

@mtx-z I opened up a PR, could you verify if it fixes the issue.

[mtx-z]

@oxyc you are right, it works with double quote. But they need to be escaped as we already are between two double quotes.

To resume:
WORK (w/ escaped double quotes):
"lint:styles": "stylelint \"resources/assets/styles/**/*.{css,sass,scss,sss,less}\""

FAIL (w/ single quotes):
"lint:styles": "stylelint 'resources/assets/styles/**/*.{css,sass,scss,sss,less}'"

WORK (without any quote, but i understand we need them)
"lint:styles": "stylelint resources/assets/styles/**/*.{css,sass,scss,sss,less}"