Add support for .ico files #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrckvzn
pushed a commit
to ptrckvzn/sage
that referenced
this pull request
Dec 1, 2016
* master: Remove sidebar defaults Replace WP codex links with developer.wordpress.org links Remove post formats Update yarn.lock [ci skip] Update CHANGELOG [ci skip] Use new webpack api schema Update dependencies Update CHANGELOG [skip ci] Update alpha references Variables organization Use $.fn.ready() (reverts 724d550) Theme activation updates 'stylesheet' option instead of 'template' Reorganize and refactor build routine Switch assets manifest plugin Add images to assets manifest Switch from babel to buble Update dependencies & webpack compatibility (BREAKING CHANGES) Use http by default (not https) to be consistent with Trellis Add support for .ico files (roots#1740) Adds Yarn package and lock file. (roots#1744)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build error
ERROR in ./assets/images/favicon.ico Module parse failed: ...sage/assets/images/favicon.ico Unexpected character '' (1:0) You may need an appropriate loader to handle this file type. (Source code omitted for this binary file) @ multi files