Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sass to style search form, remove search template #1545

Merged
merged 1 commit into from
Oct 10, 2015

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Sep 23, 2015

this PR removes the custom search template in favor of the html5 searchform from wp core. this also allows us to drop lib/utils.php. some basic form styling is added with sass, but it's different than the current searchform.

existing markup:

<form role="search" method="get" class="search-form form-inline" action="http://example.dev/">
  <label class="sr-only">Search for:</label>
  <div class="input-group">
    <input type="search" value="" name="s" class="search-field form-control" placeholder="Search Example Site" required>
    <span class="input-group-btn">
      <button type="submit" class="search-submit btn btn-default">Search</button>
    </span>
  </div>
</form>

new markup (from wp core):

<form role="search" method="get" class="search-form" action="http://example.dev/">
  <label>
    <span class="screen-reader-text">Search for:</span>
    <input type="search" class="search-field" placeholder="Search …" value="" name="s" title="Search for:">
  </label>
  <input type="submit" class="search-submit" value="Search">
</form>

existing searchform:

image

new searchform:

image

@retlehs retlehs force-pushed the remove-custom-search-template branch from 33565f9 to 9a14571 Compare October 10, 2015 17:53
retlehs added a commit that referenced this pull request Oct 10, 2015
Use Sass to style search form, remove search template
@retlehs retlehs merged commit 2fa9cd6 into master Oct 10, 2015
@retlehs retlehs deleted the remove-custom-search-template branch October 10, 2015 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant