Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WooCommerce reviews conflict #2028

Closed
5 of 6 tasks
evertsemeijn opened this issue Feb 12, 2018 · 3 comments
Closed
5 of 6 tasks

WooCommerce reviews conflict #2028

evertsemeijn opened this issue Feb 12, 2018 · 3 comments

Comments

@evertsemeijn
Copy link

Submit a feature request or bug report


What is the current behavior?
Error on single products

What is the expected or desired behavior?
Show single product

Bug report

Please provide steps to reproduce, including full log output:

  1. Install, activate, setup WooCommerce;
  2. WooCommerce > Settings > Products > 'Enable product reviews'

Output:
Fatal error: Uncaught InvalidArgumentException: Unrecognized extension in file: reviews in /app/public/wp-content/themes/xxxxxx/vendor/illuminate/view/Factory.php:258 Stack trace: #0 /app/public/wp-content/themes/xxxxxx/vendor/illuminate/view/Factory.php(227): Illuminate\View\Factory->getEngineFromPath('reviews') #1 /app/public/wp-content/themes/xxxxxx/vendor/illuminate/view/Factory.php(112): Illuminate\View\Factory->viewInstance('reviews', 'reviews', Array) #2 [internal function]: Illuminate\View\Factory->file('reviews', Array, Array) #3 /app/public/wp-content/themes/xxxxxx/vendor/roots/sage-lib/Template/Blade.php(138): call_user_func_array(Array, Array) #4 /app/public/wp-content/themes/xxxxxx/vendor/roots/sage-lib/Template/Blade.php(69): Roots\Sage\Template\Blade->__call('file', Array) #5 /app/public/wp-content/themes/xxxxxx/app/helpers.php(70): Roots\Sage\Template\Blade->compiledPath('reviews', Array) #6 /app/public/wp-content/themes/xxxxxx/app/filters.php( in /app/public/wp-content/themes/xxxxxx/vendor/illuminate/view/Factory.php on line 258

Disabling product reviews fixed it.

Please describe your local environment:

WordPress version: 4.9.4
WooCommerce version: 3.3.1

OS: -

NPM/Node version: 8.9.4

Where did the bug happen? Development or remote servers?
Both

Is there a related Discourse thread or were any utilized (please link them)?

None

@cpouldev
Copy link
Contributor

I confirm this bug.

@QWp6t
Copy link
Member

QWp6t commented Feb 14, 2018

Increase priority on comments_template filter.

app/filters.php

 add_filter('comments_template', function ($comments_template) {
 //...
-});
+, 100);

@intositeme
Copy link

I confirm this bug. @QWp6t suggestion fixed this.

oxyc added a commit to generoi/sage that referenced this issue Jun 27, 2018
* roots/master: (41 commits)
  Add uglifyjs plugin (roots#2070)
  Add missing trailing commas in 2f51b51
  Run autoprefixer before minification
  Enable source comments in Sass
  Fix travis CI build error (missing trailing comma)
  Tweaked SVGO settings
  Make template() compatible with wp admin
  9.0.1
  Update to Bootstrap 4.1.1
  Remove useless whitespace
  Auto-detect  scheme
  Close roots#2028 - Increase priority on comments_template filter
  Remove Font Awesome reference [ci skip]
  Bump sage-lib
  Close roots#1962 - Bump to Laravel 5.6
  Remove php blade shorthand
  Stable vs dev install messaging, ref roots/docs#140 [ci skip]
  Update some dependencies
  Update CHANGELOG [ci skip]
  Bootstrap 4.1.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants