Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ini_set() expects parameter 2 to be string, int given #463

Merged
merged 2 commits into from
Aug 14, 2019
Merged

ini_set() expects parameter 2 to be string, int given #463

merged 2 commits into from
Aug 14, 2019

Conversation

rubas
Copy link
Contributor

@rubas rubas commented Aug 14, 2019

Uncaught TypeError: ini_set() expects parameter 2 to be string, int given

https://www.php.net/manual/en/function.ini-set.php

rubas added 2 commits August 14, 2019 21:25
Uncaught TypeError: ini_set() expects parameter 2 to be string, int given
Uncaught TypeError: ini_set() expects parameter 2 to be string, int given
@swalkinshaw
Copy link
Member

😱 how was this never caught before. Looks correct though 👍

@swalkinshaw swalkinshaw requested a review from austinpray August 14, 2019 19:32
@austinpray
Copy link
Contributor

Yeah looks fine, peepin rn

@austinpray
Copy link
Contributor

Just tested it locally and it only occurs when decare(strict_types=1) is set at the top of application.php. Confirmed this with regular php 7 docker image php ini:

screencapture-bedrock-test-phpinfo-php-2019-08-14-14_41_20.pdf

Also

Before: https://3v4l.org/BrERf
After: https://3v4l.org/XM9SK

But yeah might as well use the right types

@austinpray austinpray merged commit cca1b04 into roots:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants