In TStreamerInfo::GenerateInfoForPair use a non-zero size enums. #6729

pcanal · 2020-10-29T16:37:22Z

This fix #6726

As reported by CMSSW tests (for example: cms-sw/cmsdist#6314 (comment)) where the data appear odd/corrupted, there is an issue in TStreamerInfo::GenerateInfoForPair (which is almost always used for std::pair in the tip of v6.22 and master).

The problem is when calculating the offset of the second data member, TStreamerInfo::GenerateInfoForPair uses (unwittingly, of course :) ), the value zero for the size of the enums.

phsft-bot · 2020-10-29T16:37:32Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

pcanal · 2020-10-29T16:37:53Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2020-10-29T16:38:00Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14 with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2020-10-29T16:39:08Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2020-10-29T16:39:07.521Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:767 (message):
[2020-10-29T16:39:07.521Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1070 (message):

phsft-bot · 2020-10-29T17:22:58Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-29T17:35:06Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-29T17:39:24Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-29T17:45:10Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-29T18:11:06Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-29T18:12:35Z

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-29T18:28:28Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

pcanal · 2020-10-29T19:20:09Z

@build just on ROOT-performance-centos8-multicore/default

pcanal · 2020-10-29T19:31:08Z

@phsft-bot build just on ROOT-performance-centos8-multicore/default

phsft-bot · 2020-10-29T19:31:16Z

Starting build on ROOT-performance-centos8-multicore/default
How to customize builds

phsft-bot · 2020-10-29T19:51:31Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

pcanal · 2020-10-29T20:47:34Z

@phsft-bot build just on ROOT-performance-centos8-multicore/default

phsft-bot · 2020-10-29T20:47:42Z

Starting build on ROOT-performance-centos8-multicore/default
How to customize builds

phsft-bot · 2020-10-29T21:14:01Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-29T23:00:38Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

pcanal · 2020-10-29T23:04:31Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2020-10-29T23:04:38Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14 with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2020-10-30T00:05:51Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-30T01:06:59Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

This fix root-project#6726 As reported by CMSSW tests (for example: cms-sw/cmsdist#6314 (comment)) where the data appear odd/corrupted, there is an issue in TStreamerInfo::GenerateInfoForPair (which is almost always used for std::pair in the tip of v6.22 and master). The problem is when calculating the offset of the second data member, TStreamerInfo::GenerateInfoForPair uses (unwittingly, of course :) ), the value zero for the size of the enums.

Search for 'kNumDataTypes'/unknown type should return nullptr not a random.

phsft-bot · 2020-10-30T01:07:22Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2020-10-30T01:07:21.106Z] CMake Error at /build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1002 (message):

phsft-bot · 2020-10-30T01:08:26Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2020-10-30T01:08:24.652Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1002 (message):

pcanal · 2020-10-30T01:09:20Z

Test will be in an upcoming roottest PR.

phsft-bot · 2020-10-30T01:11:40Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2020-10-30T01:11:38.681Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:767 (message):
[2020-10-30T01:11:38.940Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1070 (message):

phsft-bot · 2020-10-30T01:33:13Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2020-10-30T01:40:25Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2020-10-30T01:43:44Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2020-10-30T02:02:51Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2020-10-30T02:10:45Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-30T02:33:00Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2020-10-30T04:22:18Z

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

Fix root-project#6725

phsft-bot · 2020-10-30T14:00:44Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

pcanal · 2020-10-30T14:05:50Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2020-10-30T14:05:57Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14 with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

core/dictgen/src/BaseSelectionRule.cxx

core/meta/inc/TEnum.h

core/meta/src/TEnum.cxx

io/io/src/TStreamerInfo.cxx

phsft-bot · 2020-10-30T14:17:59Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-10-30T16:45:43Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

pcanal · 2020-10-30T16:45:59Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2020-10-30T16:46:07Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14 with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2020-10-30T17:44:29Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2020-10-30T18:03:45Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.runtutorials.tutorial_v7_ntuple_ntpl003_lhcbOpenData

pcanal · 2020-11-02T16:21:10Z

Test failures are unrelated.

jalopezg-git assigned pcanal Oct 29, 2020

jalopezg-git added the in:I/O label Oct 29, 2020

pcanal added 2 commits October 29, 2020 20:07

TDataType::GetDataType avoid out-of-bound reads.

22aae93

Search for 'kNumDataTypes'/unknown type should return nullptr not a random.

pcanal force-pushed the master-Issue-6726 branch from 0321ce3 to b20876d Compare October 30, 2020 01:08

pcanal requested a review from Axel-Naumann October 30, 2020 01:08

Record in the Enum underlying type in the rootpcm.

a94d94a

Fix root-project#6725

pcanal force-pushed the master-Issue-6726 branch from b20876d to a94d94a Compare October 30, 2020 14:00

Axel-Naumann approved these changes Oct 30, 2020

View reviewed changes

core/dictgen/src/BaseSelectionRule.cxx Outdated Show resolved Hide resolved

core/meta/inc/TEnum.h Outdated Show resolved Hide resolved

core/meta/src/TEnum.cxx Outdated Show resolved Hide resolved

io/io/src/TStreamerInfo.cxx Show resolved Hide resolved

pcanal added 3 commits October 30, 2020 11:37

Skip unnecessary work in TClass::GetClass

804ab49

TEnum: initilize member at declaration point.

7347360

TEnum: inline trivial accessor.

a22485e

pcanal force-pushed the master-Issue-6726 branch from 9a16ee4 to a22485e Compare October 30, 2020 16:45

pcanal merged commit 8a9a048 into root-project:master Nov 2, 2020

pcanal deleted the master-Issue-6726 branch November 2, 2020 16:21

mrodozov mentioned this pull request Nov 3, 2020

Updated root to tip of branch master cms-sw/cmsdist#6360

Merged

In TStreamerInfo::GenerateInfoForPair use a non-zero size enums. #6729

In TStreamerInfo::GenerateInfoForPair use a non-zero size enums. #6729

Conversation

pcanal commented Oct 29, 2020

phsft-bot commented Oct 29, 2020

pcanal commented Oct 29, 2020

phsft-bot commented Oct 29, 2020

phsft-bot commented Oct 29, 2020

Errors:

phsft-bot commented Oct 29, 2020

Failing tests:

phsft-bot commented Oct 29, 2020

Failing tests:

phsft-bot commented Oct 29, 2020

Failing tests:

phsft-bot commented Oct 29, 2020

Failing tests:

phsft-bot commented Oct 29, 2020

Failing tests:

phsft-bot commented Oct 29, 2020

Failing tests:

phsft-bot commented Oct 29, 2020

Failing tests:

pcanal commented Oct 29, 2020

pcanal commented Oct 29, 2020

phsft-bot commented Oct 29, 2020

phsft-bot commented Oct 29, 2020

Failing tests:

pcanal commented Oct 29, 2020

phsft-bot commented Oct 29, 2020

phsft-bot commented Oct 29, 2020

Failing tests:

phsft-bot commented Oct 29, 2020

pcanal commented Oct 29, 2020

phsft-bot commented Oct 29, 2020

phsft-bot commented Oct 30, 2020

Failing tests:

phsft-bot commented Oct 30, 2020

phsft-bot commented Oct 30, 2020

Errors:

phsft-bot commented Oct 30, 2020

Errors:

pcanal commented Oct 30, 2020

phsft-bot commented Oct 30, 2020

Errors:

phsft-bot commented Oct 30, 2020

Failing tests:

phsft-bot commented Oct 30, 2020

Failing tests:

phsft-bot commented Oct 30, 2020

Failing tests:

phsft-bot commented Oct 30, 2020

Failing tests:

phsft-bot commented Oct 30, 2020

Failing tests:

phsft-bot commented Oct 30, 2020

Failing tests:

phsft-bot commented Oct 30, 2020

Failing tests:

phsft-bot commented Oct 30, 2020

pcanal commented Oct 30, 2020

phsft-bot commented Oct 30, 2020

phsft-bot commented Oct 30, 2020

phsft-bot commented Oct 30, 2020

pcanal commented Oct 30, 2020

phsft-bot commented Oct 30, 2020

phsft-bot commented Oct 30, 2020

Failing tests:

phsft-bot commented Oct 30, 2020

Failing tests:

pcanal commented Nov 2, 2020