Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][TReentrantRWLock] Add missing variable definition #6382

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

stwunsch
Copy link
Contributor

@stwunsch stwunsch commented Sep 18, 2020

I really wonder why this is only picked up by windows?

Edit: It's the macro 😬

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-1.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Warnings:

  • [2020-09-18T11:30:07.788Z] /build/workspace/root-pullrequests-build/root/core/thread/src/TReentrantRWLock.cxx:323:12: warning: variable ‘local’ set but not used [-Wunused-but-set-variable]
  • [2020-09-18T11:30:07.788Z] /build/workspace/root-pullrequests-build/root/core/thread/src/TReentrantRWLock.cxx:323:12: warning: variable ‘local’ set but not used [-Wunused-but-set-variable]
  • [2020-09-18T11:30:07.788Z] /build/workspace/root-pullrequests-build/root/core/thread/src/TReentrantRWLock.cxx:323:12: warning: variable ‘local’ set but not used [-Wunused-but-set-variable]
  • [2020-09-18T11:30:07.788Z] /build/workspace/root-pullrequests-build/root/core/thread/src/TReentrantRWLock.cxx:323:12: warning: unused variable ‘local’ [-Wunused-variable]
  • [2020-09-18T11:30:07.788Z] /build/workspace/root-pullrequests-build/root/core/thread/src/TReentrantRWLock.cxx:323:12: warning: unused variable ‘local’ [-Wunused-variable]
  • [2020-09-18T11:30:07.788Z] /build/workspace/root-pullrequests-build/root/core/thread/src/TReentrantRWLock.cxx:323:12: warning: unused variable ‘local’ [-Wunused-variable]

Failing tests:

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-1.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@pcanal pcanal mentioned this pull request Sep 18, 2020
@phsft-bot
Copy link
Collaborator

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See cdash.
See console output.

Errors:

  • [2020-09-18T12:04:22.487Z] C:\build\workspace\root-pullrequests-build\root\core\thread\src\TReentrantRWLock.cxx(323,1): error C2664: 'bool ROOT::Internal::UniqueLockRecurseCount::IsNotCurrentWriter(ROOT::Internal::UniqueLockRecurseCount::local_t &)': cannot convert argument 1 from 'ROOT::Internal::UniqueLockRecurseCount::local_t' to 'ROOT::Internal::UniqueLockRecurseCount::local_t &' [C:\build\workspace\root-pullrequests-build\build\core\thread\Thread.vcxproj]

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@pcanal pcanal assigned pcanal and unassigned stwunsch Sep 18, 2020
@pcanal pcanal added this to the 6.24/00 milestone Sep 18, 2020
@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-1.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@pcanal pcanal merged commit 7d05bbd into root-project:master Sep 18, 2020
mrodozov added a commit to mrodozov/cmsdist that referenced this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants