[RDF] Extend three RDF tests #19562
Open
[RDF] Extend three RDF tests #19562
+111
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a precompiled snapshot, the code that was used to test jitted vs templated is now identical, so it can be removed.
- Make the array longer instead of shorter. - Fill the array with changing values. - Add a static_assert to ensure that the array size really changes. - Provide a multi-threaded version of the test.
Instead of testing in a for loop, (which possibly prints 10k failures), use std::all_of to make a test output more readable. Furthermore, test the size of the 3rd collection, which maybe just got forgotten.
When columns got redefined, snapshot was trying to still find input columns for the outputs. That should not be the case since none of the properties of the input branch need to be transferred.
hageboeck
force-pushed
the
snapshot_vary_prologue
branch
from
7a9d8c0 to
155dcdb
Compare
vepadulano
approved these changes
Aug 7, 2025
Test Results 21 files 21 suites 3d 8h 48m 51s ⏱️ For more details on these failures, see this check. Results for commit 1a82395. ♻️ This comment has been updated with latest results. |
The code for updating branch addresses of TBranchElement instances was triggered only in the context of a Redefine. Here, a test with a Define is added to increase the coverage in snapshot with multiple input files.
hageboeck
force-pushed
the
snapshot_vary_prologue
branch
from
fe05c22 to
1a82395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During work on snapshot with variations, these three snapshot tests were refined slightly to make the failures more readable or to slightly extend coverage.
Update: