[ntuple] Allow modifying model fields #16713
Draft
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to modify fields, for example to change the column representation. It also fixes the assymmetry where previously the const version could always be called, but the non-const version would throw if the model was unfrozen.
pcanal
reviewed
Oct 18, 2024
| } | ||
| model->GetField("v2._0").SetColumnRepresentatives({{EColumnType::kReal16}}); | ||
|
|
||
| EXPECT_EQ(EColumnType::kReal32, model->GetField("v1._0").GetColumnRepresentatives()[0][0]); |
There was a problem hiding this comment.
Wouldn't be more 'mainstream' to add (even if spurious here) a call to 'freeze' in the 'right' place?
There was a problem hiding this comment.
Yes, Jakob and me noticed that we first need to solve some other issues though: #16714
Test Results 18 files 18 suites 4d 0h 47m 28s ⏱️ For more details on these failures, see this check. Results for commit 69baf3d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.