[cling] Windows: Fix declaration for C99 and re-enable Gnu.C test #16694
Conversation
The test was failing for a reason that likely shouldn't be ignored. This reverts commit 5947e13. This is a rebased version of root-project/cling#174 by marsupial
Test Results 17 files 17 suites 4d 1h 29m 47s ⏱️ For more details on these failures, see this check. Results for commit b605efc. |
There was a problem hiding this comment.
lgtm, but I would like that also @vgvassilev approves before moving on with the merge.
|
Do we have a way to run the cling tests in the ci? |
That would be #15230 |
Ok, so it's not there yet. @ferdymercury, did you try to run the cling tests locally? Does this change still lead to successful testsuite? |
|
No, I didn't, sorry. I just rebased an existing PR, I think at that time, it was tested with jenkins. See discussion here: root-project/cling#174 (comment) |
Ok, 7 years ago the tests were fine. Are they now? We should probably implement the feature request you mentioned earlier. |
This Pull request:
Changes or fixes:
This is a rebased version of root-project/cling#174 by @marsupial
The test was failing for a reason that likely shouldn't be ignored. This reverts commit root-project/cling@5947e13.
Checklist: