[CI] Add a GPU runner. #16580
Merged
[CI] Add a GPU runner. #16580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hageboeck
commented
Oct 2, 2024
•
hageboeck
commented
- Add a new job to run with cuda
- Select GPU-enabled runners
- Pass host GPU into container
Test Results 17 files 17 suites 4d 1h 29m 6s ⏱️ For more details on these failures, see this check. Results for commit 2694d5d. ♻️ This comment has been updated with latest results. |
hageboeck
force-pushed
the
gpuCI
branch
8 times, most recently
from
88919dc
to
fba5543
Compare
guitargeek
reviewed
Oct 10, 2024
hageboeck
force-pushed
the
gpuCI
branch
17 times, most recently
from
abf35da
to
1ae17f0
Compare
dpiparo
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Thanks for this improvement of the CI. For me the PR is ready to be merged, once we verify once again it works fine.
Maybe we want to consider restricting the testing only to the tests that use the GPU (a set we'll be expanding in the next few months, now that we have the build), in order to optimise the usage of the device w/o spending 30 minutes running the full test suite on CPU.
hageboeck
force-pushed
the
gpuCI
branch
2 times, most recently
from
6db9141
to
88696d4
Compare
1 task
- Add a new run with cuda=On. - Create a build config file for ubuntu2404-cuda. - Map nvidia GPUs into the container when running with cuda.
RooBatchCompute is using host pointers in a kernel, which is hard to detect. This assertion helps to catch the error a lot earlier.
The choice should be made based on the input size, and not based on the output size.
When webgui=Off, a simple notebook test times out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.