Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Support weighted filling from RDF to RooFit in RooAbsDataHelper #16091

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

guitargeek
Copy link
Contributor

Support weighted filling from RDF to RooFit in RooAbsDataHelper and also
implement a test for it.

Closes #7223.

Copy link

github-actions bot commented Jul 23, 2024

Test Results

    13 files      13 suites   2d 21h 12m 34s ⏱️
 2 679 tests  2 677 ✅ 0 💤 2 ❌
32 728 runs  32 724 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit ddfbe3d.

♻️ This comment has been updated with latest results.

Copy link
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This will make it easier to have implementation differences for
RooDataHist and RooDataSet.
Support weighted filling from RDF to RooFit in RooAbsDataHelper and also
implement a test for it.

Closes root-project#7223.
@guitargeek guitargeek merged commit 4838950 into root-project:master Jul 23, 2024
14 of 18 checks passed
@guitargeek guitargeek deleted the issue-7223 branch July 23, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RF] RDataFrame to RooDataSet/RooDataHist conversion
2 participants