Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORC] Preserve order of constructors with same priority [v6.30] #15858

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Jun 14, 2024

Constructors with the same priority should keep their relative order that was specified. This is important for clang-repl with many const variables after commit llvm/llvm-project@05137ec ("[clang-repl] Emit const variables only once").


Fixes #15511

(version of commit a60f353 for LLVM 13 in v6-30-00-patches, backport of #15854)

Constructors with the same priority should keep their relative order
that was specified. This is important for clang-repl with many const
variables after commit 05137ecfca ("[clang-repl] Emit const variables
only once").

---

Fixes root-project#15511

(version of commit a60f353 for
LLVM 13 in v6-30-00-patches)
Copy link

Test Results

    11 files      11 suites   2d 5h 33m 7s ⏱️
 2 589 tests  2 589 ✅ 0 💤 0 ❌
26 761 runs  26 761 ✅ 0 💤 0 ❌

Results for commit 130a47b.

Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this fix!

@hahnjo hahnjo merged commit db2a418 into root-project:v6-30-00-patches Jun 17, 2024
15 checks passed
@hahnjo hahnjo deleted the orc-ctor-order-v630 branch June 17, 2024 12:25
@pikacic
Copy link

pikacic commented Jun 18, 2024

I tested this and I can confirm I do not see the segfault anymore. Can you have a 6.30 tag, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants