Exclude usage of nlohmann/json_fwd.hpp from REve [6.30]
#14643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was necessary before while interpreter had problems to correctly parse it. Starting from llvm 13 it is no longer the problem
No longer used and no longer required
linev
requested review from
bellenot,
osschar and
Axel-Naumann
as code owners
|
Starting build on |
Test Results 9 files 9 suites 1d 9h 46m 31s ⏱️ For more details on these failures, see this check. Results for commit 059a4cf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before llvm 13 it was not possible to parse
nlohmann/json.hppinclude. Thereforejson_fwd.hppwas used.But it was missing on several platforms where external
nlohmann/json.hpphas to be used.Now after llvm upgrade it is not necessary to use it.
This should simplify ROOT building and usage on platforms with installed
nlohmann/json.hpp.Also should fix #14634