Print a warning when the range given to SetRange is invalid. #14589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
Test Results 10 files 10 suites 1d 17h 19m 31s ⏱️ Results for commit 2e791b9. |
lmoneta
requested changes
Feb 15, 2024
hist/hist/src/TAxis.cxx
Outdated
| fFirst = std::max(first, 0); | ||
| if (last>nCells) Warning("TAxis::SetRange","last > fNbins, fNbins is used"); |
There was a problem hiding this comment.
Here should be:
if (last>nCells) Warning("TAxis::SetRange","last > fNbins+1, fNbins+1 is used");
|
Starting build on |
|
Build failed on mac12arm/cxx20. Errors:
|
lobis
pushed a commit
to lobis/root
that referenced
this pull request
Apr 10, 2024
…oject#14589) * Print a warning when the range given to SetRange is invalid. * Fix comment
silverweed
pushed a commit
to silverweed/root
that referenced
this pull request
Aug 19, 2024
…oject#14589) * Print a warning when the range given to SetRange is invalid. * Fix comment
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested here: #9917