Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tutorial] How to create ROOT Dictionary for a custom class is a stand-alone C++ project #13205
[Tutorial] How to create ROOT Dictionary for a custom class is a stand-alone C++ project #13205
Changes from 31 commits
d942c13
b33ef85
0bbff47
1104f8e
74f5837
c8cf91d
566019d
7bb519a
5c87723
ee0adaa
a476225
c7be2ca
3184750
2bbd027
322663c
75fe159
ea91a9b
db5f376
c2811c0
ff8990a
c27ba72
f187820
8918f82
5d68c66
0566cd2
9ee2527
dabe214
556f639
d998e6e
caf5a05
191250e
5e694ff
ddcef7e
825ddc5
7a2e0b0
92ae246
edb9278
264d23e
3ddec6f
03c72c6
7df705d
d835e4b
63f13e3
f7f9fe4
238b980
9ae5a98
49ee1f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way of including ROOT is a bit outdated, see a more modern way here: https://cliutils.gitlab.io/modern-cmake/chapters/packages/ROOT.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I think those tips are worth to be included as part of the official ROOT documentation :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just out of curiosity, is the dot at the end of the branch name needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dot at the end of the branch is semantically relevant and recommended. If you have a dot at the end of the name and the branch contains an object that is split (which is the default), the sub-branch names will be prefixed by the name of the top level branch. WIthout the dot, the prefix is not there. For example with the dot you get the sub branch names:
without it you get:
So in case there same data member name appears in multiple branches adding the dot removes ambiguities. (In this example, this is the case since we have 2 branches containing the same data type).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! I think that information is important enough to be part of the documentation :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see trace of it in https://root.cern.ch/doc/master/classTTree.html