[RF] Improvements to RooAbsPdf::paramOn() formatting
#12608
Conversation
guitargeek
requested review from
lmoneta,
hageboeck and
Axel-Naumann
as code owners
|
Starting build on |
The `Format(const char*, int)` command arg for `RooAbsPdf::paramOn()` is long superseeded by `Format(const char*, ...)`, which takes additional command arguments instead of a single additional integer to specify the number of significant digits.
Closes JIRA issue 6039: https://sft.its.cern.ch/jira/browse/ROOT-6039 In the issue, it was suggested to make that the default, but I think this is a too drastic change. People often have long variable titles, and putting these by default in the plot labels might mess up the plots. As a compromise, this commit suggests an easy option to change the behavior of `paramOn()`, just using `T` in the format string instead of `N`.
|
Starting build on |
| @@ -3190,13 +3152,10 @@ RooPlot* RooAbsPdf::paramOn(RooPlot* frame, const RooAbsData* data, const char * | |||
| /// values specify the initial relative position of the text box in the plot frame. | |||
|
|
|||
| RooPlot* RooAbsPdf::paramOn(RooPlot* frame, const RooArgSet& params, bool showConstants, const char *label, | |||
There was a problem hiding this comment.
Here you are changing the paramOn interface. Can the old one be kept for backward compatibility and mark as deprecated and maybe removed later on ?
There was a problem hiding this comment.
This is private function that is an implementation detail which is called by the public paramOn() function. So it doesn't matter if the change the interface
There was a problem hiding this comment.
Good! I missed it was a private function.
Two changes:
RooFit::Format(const char* option, int)command argumentRooAbsPdf::paramOn()overload that take a formatting string directlyRooAbsPdf::paramOn(), closing the followng JIRA ticket:https://sft.its.cern.ch/jira/browse/ROOT-6039
More detail in the commit descriptions.