[RF] RooBarlowBeestonLL: Avoid removing elements of RooArgSet while looping over them #10921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 7, 2022 11:00
This reverts commit bf566b6.
|
Can one of the admins verify this patch? |
|
@phsft-bot build |
|
Starting build on |
guitargeek
changed the title
16 tasks
guitargeek
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
LGTM, thank you so much for investigating and fixing this error! Really awesome 👍
As this is an important bugfix, I will also backport this to the 6.26 branch to enter the next 6.26 patch release.
This PR fixes the following issue reported on the forum:
https://root-forum.cern.ch/t/problems-with-histfactory-and-beeston-barlow-light-statistical-uncertainty
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Avoid removing elements of
RooArgSetinRooBarlowBeestonLLwhile looping over them. This was broken since ROOT v6.18, afterRooAbsCollectionwas moved tostd::vector. This (re)enables the analytical treatment of statistical uncertainties in bins with the Barlow-Beeston-Lite procedure.Changes or fixes:
As described above.
Checklist:
This PR fixes #