-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: add restore mon quorum in go #88
Conversation
03751d3
to
93555a4
Compare
3b6c319
to
b53e6fe
Compare
beda974
to
17c2b74
Compare
found one issue working on the fix. |
17c2b74
to
4d3c8a2
Compare
8a4389b
to
156be14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing locally, I saw that the restored mon pod has the sleep infinity
command instead of having the original ceph-mon
command restored. I wouldn't expect the command to be modified on the mon. It should have just been modified on the mon debug pod. If you fix this command when starting back up the mon, hopefully the quorum will start again.
thanks @travisn I,ll check and update. |
d9f02f0
to
cebe29d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more small changes...
f4bf0ec
to
8abcfa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commits look like they aren't strictly needed. How about squashing them? Then a separate commit for the log collector likely makes sense.
which commits @travisn, could enter the title not able to get the commit from the comment. |
8abcfa8
to
7a11bd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you just update the commit description? It should discuss the command to restore mon quorum, instead of just talking about other small changes.
7a11bd0
to
76feb3e
Compare
76feb3e
to
57a6f19
Compare
this commits add a go command for restore the mon quorum from single good mon. In the background we, scale down the operator first, and run some ceph commands like remove bad mans from mon map, extracting/injecting monmap. And, in the end, we scale up the operator which bring back the mon quorum. Signed-off-by: subhamkrai <srai@redhat.com>
57a6f19
to
7f32adb
Compare
core: add restore mon quorum in go
this commits add a go command for
restore the mon quorum from single
good mon. In the background we,
scale down the operator first, and run some
ceph commands like remove bad mans from
mon map, extracting/injecting monmap.
And, in the end, we scale up the operator which
bring back the mon quorum.
Signed-off-by: subhamkrai srai@redhat.com