Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of random wait time in CI, read the resource details using Timeout #42

Closed
parth-gr opened this issue Aug 3, 2022 · 3 comments · Fixed by #48
Closed

Instead of random wait time in CI, read the resource details using Timeout #42

parth-gr opened this issue Aug 3, 2022 · 3 comments · Fixed by #48
Assignees
@parth-gr

Comments

@parth-gr
Copy link
Member

parth-gr commented Aug 3, 2022 

+ kubectl rook_ceph -o test-operator -n test-cluster rbd ls replicapool
rbd: error opening pool 'replicapool': (2) No such file or directory
rbd: listing images failed: (2) No such file or directory
command terminated with exit code 2
Error: Process completed with exit code 2.

The CI failed because the wait time was not enough to reconcile the operator completely,

Instead of adding random wait time, we can read the resource until it becomes ready using Timeout,

LIke : https://github.com/rook/rook/blob/ec0c9a7963357fcd9023fc8d7c28720fe6f3c810/.github/workflows/canary-integration-test.yml#L59
@subhamkrai
Copy link
Collaborator

after this fix #38 I have not seen a CI issue, before this, I faced but not once was this merged.
try rebasing.

@parth-gr
Copy link
Member Author

parth-gr commented Aug 3, 2022

@subhamkrai You can see my PR is already on top of it #36

Still, the CI fails with this error,

And anyhow using Timeout would be a good practice in time, when the CI would be growing more with commands:)

@subhamkrai
Copy link
Collaborator

right, checking for resource is better
Feel free to raise the pr

@parth-gr parth-gr mentioned this issue Aug 5, 2022
Merged
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 22, 2022
@parth-gr
ci: added timeout instead of sleep commands
eb749b8 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
@parth-gr parth-gr mentioned this issue Aug 22, 2022
Merged
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 23, 2022
@parth-gr
ci: added timeout instead of sleep commands
7264459 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 24, 2022
@parth-gr
ci: added timeout instead of sleep commands
39d0ad4 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 29, 2022
@parth-gr
ci: added timeout instead of sleep commands
ab92859 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 29, 2022
@parth-gr
ci: added timeout instead of sleep commands
7f40189 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 30, 2022
@parth-gr
ci: added timeout instead of sleep commands
4038d50 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 30, 2022
@parth-gr
ci: added timeout instead of sleep commands
ebba2a8 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 30, 2022
@parth-gr
ci: added timeout instead of sleep commands
e8637f4 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 30, 2022
@parth-gr
ci: added timeout instead of sleep commands
e95959a 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 30, 2022
@parth-gr
ci: added timeout instead of sleep commands
94c8bb2 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 30, 2022
@parth-gr
ci: added timeout instead of sleep commands
d7e1b35 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 30, 2022
@parth-gr
ci: added timeout instead of sleep commands
a5f1950 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 30, 2022
@parth-gr
ci: added timeout instead of sleep commands
c715229 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 30, 2022
@parth-gr
ci: added timeout instead of sleep commands
efc09ca 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 30, 2022
@parth-gr
ci: added timeout instead of sleep commands
4beed78 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Aug 30, 2022
@parth-gr
ci: added timeout instead of sleep commands
8b73d17 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 1, 2022
@parth-gr
ci: added timeout instead of sleep commands
f9b4b15 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 1, 2022
@parth-gr
ci: added timeout instead of sleep commands
80a3901 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 1, 2022
@parth-gr
ci: added timeout instead of sleep commands
cb44834 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 1, 2022
@parth-gr
ci: added timeout instead of sleep commands
75dec6d 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 1, 2022
@parth-gr
ci: added timeout instead of sleep commands
9ff7543 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 1, 2022
@parth-gr
ci: added timeout instead of sleep commands
48c1dc0 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 6, 2022
@parth-gr
ci: added timeout instead of sleep commands
fca6bea 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 6, 2022
@parth-gr
ci: added timeout instead of sleep commands
0012fec 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 6, 2022
@parth-gr
ci: added timeout instead of sleep commands
848ac32 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 6, 2022
@parth-gr
ci: added timeout instead of sleep commands
4b8efdb 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 8, 2022
@parth-gr
ci: added timeout instead of sleep commands
0f1fc79 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 15, 2022
@parth-gr
ci: added timeout instead of sleep commands
bead634 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 15, 2022
@parth-gr
ci: added timeout instead of sleep commands
89ac7d6 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 15, 2022
@parth-gr
ci: added timeout instead of sleep commands
f0ee427 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 20, 2022
@parth-gr
ci: added timeout instead of sleep commands
c1c239b 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 20, 2022
@parth-gr
ci: added timeout instead of sleep commands
6b76704 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 21, 2022
@parth-gr
ci: added timeout instead of sleep commands
6a32072 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 21, 2022
@parth-gr
ci: added timeout instead of sleep commands
d2b818e 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 22, 2022
@parth-gr
ci: added timeout instead of sleep commands
f77ed36 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 22, 2022
@parth-gr
ci: added timeout instead of sleep commands
5a87b34 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 27, 2022
@parth-gr
ci: added timeout instead of sleep commands
d4cc8ae 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 27, 2022
@parth-gr
ci: added timeout instead of sleep commands
8f5555e 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Sep 28, 2022
@parth-gr
ci: added timeout instead of sleep commands
102b2dc 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 17, 2022
@parth-gr
ci: added timeout instead of sleep commands
7080236 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 18, 2022
@parth-gr
ci: added timeout instead of sleep commands
cb527dc 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 19, 2022
@parth-gr
ci: added timeout instead of sleep commands
e83b6e8 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 20, 2022
@parth-gr
ci: added timeout instead of sleep commands
3007d8d 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 20, 2022
@parth-gr
ci: added timeout instead of sleep commands
2fa0110 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 20, 2022
@parth-gr
ci: added timeout instead of sleep commands
40d3463 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 20, 2022
@parth-gr
ci: added timeout instead of sleep commands
92096a6 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 20, 2022
@parth-gr
ci: added timeout instead of sleep commands
7b1cb40 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 20, 2022
@parth-gr
ci: added timeout instead of sleep commands
312bc5b 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 20, 2022
@parth-gr
ci: added timeout instead of sleep commands
136b11a 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 20, 2022
@parth-gr
ci: added timeout instead of sleep commands
27d4e14 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/kubectl-rook-ceph that referenced this issue Oct 20, 2022
@parth-gr
ci: added timeout instead of sleep commands
4dc05b5 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
subhamkrai pushed a commit to subhamkrai/kubectl-rook-ceph that referenced this issue Nov 10, 2022
@parth-gr @subhamkrai
ci: added timeout instead of sleep commands
88ea41e 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
subhamkrai pushed a commit to subhamkrai/kubectl-rook-ceph that referenced this issue Nov 10, 2022
@parth-gr @subhamkrai
ci: added timeout instead of sleep commands
169bc6d 
Instead of random sleep time, added timeout
so we will wait till the pods get started

Closes: rook#42
Signed-off-by: parth-gr <paarora@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parth-gr parth-gr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: added timeout instead of sleep commands parth-gr/kubectl-rook-ceph
2 participants
@subhamkrai @parth-gr