[moveos_std] Handle object id and decimal value for json #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
jolestar
reviewed
Feb 27, 2025
jolestar
reviewed
Feb 27, 2025
Comment on lines
+305
to
+309
| let decimal_value = decimal_value::new(1000000, 6); | ||
| let decimal_value_json = to_json(&decimal_value); | ||
|
|
||
| let from_decimal_value = from_json<DecimalValue>(decimal_value_json); | ||
| assert!(decimal_value == from_decimal_value, 1); |
There was a problem hiding this comment.
decimal_value to_json 后是 json 的 float 类型吗？
There was a problem hiding this comment.
意思是直接to_json 后直接表达成 float 类型，例如 3.14156 这样？现在是 struct 的表达结构
There was a problem hiding this comment.
DecimalValue 就是为了能表达 float 类型。如果是 struct 结构就没必要专门处理了。
jolestar
reviewed
Feb 28, 2025
| public fun new_object_id_for_test(path: vector<address>): ObjectID { | ||
| ObjectID { path } | ||
| } | ||
|
|
There was a problem hiding this comment.
可以多一个，很多测试用例中需要生成 ObjectID
#[test_only]
public fun derive_object_id_for_test():ObjectID{
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary