Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the OpenID connect spec:
Right now, if a client passes a "nounce", we don't give it back and
the client fails. This is happening to me right now with the client
from Matrix Synapse.
Here, I'm creating a new service (
CurrentRequestService
).With this new service, I can get the current PSR-7 request.
I extend the AuthCodeGrant and inject this service into the extended class.
With this, I can:
Then, in the
IdTokenResponse
, I read the "code" (if it is present),extract the "nounce" and inject it in the ID token as a new claim.
The whole process is inspired by this comment: steverhoades/oauth2-openid-connect-server#47 (comment)
With those changes, nounce is correctly handled and I've successfully
tested a connection with the OpenID client from Matrix Synapse.
This PR is built on top of #16