refactor: styling implementation #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronimizy
added
bug
Source/FluentSpreadsheets.GoogleSheets/Extensions/AlignmentExtensions.cs
Show resolved
Hide resolved
Mihinator3000
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactored implementation of applying styles. Core idea was the cascading styles, so the styles from higher level components would be applied to lower level components. Pervious implementation had a limitation of priority of top level styles over lower level styles, which is unfortunate, because component specific rules should have a higher priority. Issue could be observed on containers.
Why
That limitation came from a structure of styling components, it was an unordered composition, meaning the higher styling component in composition - the higher priority is has.
How
The composition is now ordered! There is now only one styling component type, which is located on top of the component composition (or not, if there was no styling applied). Now, when you want to apply style to component composition A, you will create a new styling component instance with new style applied to an old style with component wrapped in composition A's styling component, if composition A does not have a styling component - the new instance will be created.