Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to bitflags 2.0 #443

Merged
merged 4 commits into from
May 1, 2023
Merged

Upgrade to bitflags 2.0 #443

merged 4 commits into from
May 1, 2023

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Mar 13, 2023

Supersedes #442. Updates the bitflags dependency to 2.0

Breaking change:

  • bitflags 2.0 serializes differently, now using the names instead of (bits: 42). Did we ever commit to how Extensions is serialized?

@kvark bitflags-serial still uses bitflags 1.0, so I've removed the related test for now. Feel free to re-add it or ping me once bitflags-serial is updated

  • I've included my change in CHANGELOG.md

@juntyr
Copy link
Member Author

juntyr commented Mar 13, 2023

?r @torkleyy

@juntyr juntyr requested a review from torkleyy March 13, 2023 19:49
@juntyr juntyr self-assigned this Mar 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@c0d7421). Click here to learn what that means.
Patch coverage: 83.33% of modified lines in pull request are covered.

❗ Current head ff48634 differs from pull request most recent head 951c88b. Consider uploading reports for the commit 951c88b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #443   +/-   ##
=========================================
  Coverage          ?   86.50%           
=========================================
  Files             ?       61           
  Lines             ?     7983           
  Branches          ?        0           
=========================================
  Hits              ?     6906           
  Misses            ?     1077           
  Partials          ?        0           
Impacted Files Coverage Δ
src/de/mod.rs 75.13% <ø> (ø)
src/extensions.rs 81.57% <50.00%> (ø)
tests/152_bitflags.rs 52.05% <85.71%> (ø)
src/value/raw.rs 88.65% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juntyr juntyr merged commit ec889b5 into ron-rs:master May 1, 2023
@juntyr juntyr deleted the bitflags-2.0 branch May 1, 2023 10:16
juntyr added a commit to juntyr/ron that referenced this pull request Aug 15, 2023
* Upgrade to bitflags 2.0

* Update the fuzzer Cargo.lock
juntyr added a commit to juntyr/ron that referenced this pull request Aug 16, 2023
* Upgrade to bitflags 2.0

* Update the fuzzer Cargo.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants