Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected halt 2.6.0 #38

Open
jicuss opened this issue Dec 26, 2024 · 1 comment
Open

unexpected halt 2.6.0 #38

jicuss opened this issue Dec 26, 2024 · 1 comment

Comments

@jicuss
Copy link

jicuss commented Dec 26, 2024

File "/usr/local/lib/python3.11/dist-packages/urllib3/contrib/_socks_override.py", line 80, in <module> [2024-12-26, 10:05:46 PST] {pod_manager.py:472} INFO - [base] class AsyncioProxy(abc.AsyncProxy): # type: ignore[misc] [2024-12-26, 10:05:46 PST] {pod_manager.py:472} INFO - [base] ^^^^^^^^^^^^^^ [2024-12-26, 10:05:46 PST] {pod_manager.py:490} INFO - [base] AttributeError: module 'python_socks._abc' has no attribute 'AsyncProxy'

this was unexpected, isolated to todays deployment. downgrading resolved. should we be expecting breaking changes on a minor version difference?

python-socks==2.5.3 worked

@romis2012
Copy link
Owner

Class python_socks._abc.AsyncProxy is redundant and was removed in version 2.6.0. Moreover, this class was "private" and was not a part of python-socks public API.

It seems you should create an issue here https://github.com/jawah/urllib3.future

Ousret added a commit to jawah/urllib3.future that referenced this issue Jan 12, 2025
ignore the warning introduced in v2.6 about "_socket" arg.
users noticed the break at romis2012/python-socks#38
we want to find a compromise about the recent deprecation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants