fix(rome_js_analyzer): Big pack of js/ts files that crashes rome #4323

[denbezrukov]

Summary

Fix a semantic model crash when we have JsBogusBinding.

function _13_1_3_fun(arguments) { }

        0: JS_FUNCTION_DECLARATION@0..44
          0: (empty)
          1: FUNCTION_KW@0..18 "function" [Newline("\n"), Whitespace("        ")] [Whitespace(" ")]
          2: (empty)
          3: JS_IDENTIFIER_BINDING@18..29
            0: IDENT@18..29 "_13_1_3_fun" [] []
          4: (empty)
          5: JS_PARAMETERS@29..41
            0: L_PAREN@29..30 "(" [] []
            1: JS_PARAMETER_LIST@30..39
              0: JS_FORMAL_PARAMETER@30..39
                0: JS_BOGUS_BINDING@30..39
                  0: IDENT@30..39 "arguments" [] []
                1: (empty)
                2: (empty)
                3: (empty)
            2: R_PAREN@39..41 ")" [] [Whitespace(" ")]
          6: (empty)

We have the crash here for the NoParameterAssign rule:

tools/crates/rome_js_semantic/src/semantic_model/model.rs

Lines 330 to 337 in dad13a9

	pub fn as_binding(&self, binding: &impl IsBindingAstNode) -> Binding {
	let range = binding.syntax().text_range();
	let id = &self.data.bindings_by_range[&range];
	Binding {
	data: self.data.clone(),
	index: (*id).into(),
	}
	}

I believe that we can ignore any bogus nodes while we do an analysis.

Test Plan

cargo test

Changelog

• The PR requires a changelog line

Documentation

• The PR requires documentation
• I will create a new PR to update the documentation

[netlify]

✅ Deploy Preview for docs-rometools canceled.

Name	Link
🔨 Latest commit	dc6a766
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rometools/deploys/6486c404dadd0a0008bf8c82

[ematipico]

Looks good. The analyzer ignores broken syntax, so it makes sense that the semantic model did the same