This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Implement new website #3556
Merged
Implement new website #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for rometools failed.
|
|
Took a screenshot of some accessibility issues with Firefox, documentation page. The list is not exhaustive:
|
added 2 commits
November 3, 2022 17:57
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
added 2 commits
November 3, 2022 22:52
FeedbackOverall: Looks awesome! Some feedback from clicking through the page
Must use
Link to the announcement blog post that goes into more detail. The main performance boost comes from the monolithic design and careful design of our data structures
TOC We should re-visit the headings with {data-toc-exclude}. May no longer be necessary, now that they don't appear in the main navigation
I find it somewhat difficult to "parse" the hierarchy on the rules page. |
added 2 commits
November 4, 2022 13:10
|
Addressed all current feedback. Keeping the main post TODOs up to date. |
jeysal
added a commit
to jeysal/rometools
that referenced
this pull request
Nov 8, 2022
* upstream/main: fix(ci): fix the release workflows for the stable release (rome#3583) Fix logo container margin Fix mobile docs regressions perf: End-to-end Linter and Formatter benchmarks (rome#3570) doc: VS Code extension (rome#3579) refactor(rome_cli): refactor the threading of parallel traversal to increase occupancy (rome#3577) [docs] Add navigation dropdown for docs (rome#3578) doc(rome_cli): Document `--files-max-size` option perf(rome_js_semantic): Use FX Hash function (rome#3565) fix(rome_js_analyzer): `noInvalidConstructorSuper` false positive for class expressions (rome#3561) Clean up mobile navigation doc(website): Run `cargo lintdoc` (rome#3567) doc: Fix install command Fix mobile code blocks Fix dark mode logo Update links Implement new website (rome#3556)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a new website design. We plan on shipping this next week. This PR is still WIP. Things that need to be done:
release/10.0.0branch website changesog:imagefor v10 blog postTest Plan
Netlify. Local development.