Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDifferencePercent fix (#233) #239

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nikmazur
Copy link

@nikmazur nikmazur commented Nov 2, 2022

PR Details

Fix to getDifferencePercent method in ImageComparisonUtil

Description

The getDifferencePercent was calculating pixels incorrectly: instead of calculating each different pixels towards the overall counter, it was using an overall sum of differences. This PR fixes that.

Related Issue

#233

Motivation and Context

getDifferencePercent can be used to retrieve exact % of differences for ignoring them in ImageComparisonResult config. This can be used to individually configure tests with different images to pass.

How Has This Been Tested

I have ran and updated the existing tests, and also added a new one which gets and sets percentage of differences. I have also tested these changes in my own project, which uses this library with Selenide for Web visual testing:
https://github.com/nikmazur/ui-visual-testing

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant