Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Fix to getDifferencePercent method in ImageComparisonUtil
Description
The getDifferencePercent was calculating pixels incorrectly: instead of calculating each different pixels towards the overall counter, it was using an overall sum of differences. This PR fixes that.
Related Issue
#233
Motivation and Context
getDifferencePercent can be used to retrieve exact % of differences for ignoring them in ImageComparisonResult config. This can be used to individually configure tests with different images to pass.
How Has This Been Tested
I have ran and updated the existing tests, and also added a new one which gets and sets percentage of differences. I have also tested these changes in my own project, which uses this library with Selenide for Web visual testing:
https://github.com/nikmazur/ui-visual-testing
Types of changes
Checklist