Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor apps configuration to explicitly define program path and type #23

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

krovuxdev
Copy link
Contributor

Issue solved: the application was not running correctly with nix run.

@romancitodev
Copy link
Owner

Small change, looks fine (I don't use NixOs so I assume that's correct).

I approve this, idk about other core contributors that uses Nix.

@romancitodev romancitodev self-requested a review August 13, 2024 23:36
@romancitodev
Copy link
Owner

@SergioRibera What do you think?

Copy link
Contributor

@SergioRibera SergioRibera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, I just realized that with the binary change it stopped working command

@krovuxdev
Copy link
Contributor Author

It looks great, I just realized that with the binary change it stopped working command

Why? It worked fine for me. Could you please check my PR again and try running the command?

@romancitodev romancitodev merged commit 54ed230 into romancitodev:main Aug 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants